CI: migrate to Bento#427
Merged
Merged
Conversation
Drive-by: pin actions/checkout to a known-good commit hash
hanwen-flow
approved these changes
May 26, 2026
| - "engflow-job-name=ci-runners-test-matrix-${{matrix.remote_execution}}_${{matrix.allow_bento_snapshot}}" | ||
| - "engflow-job-type=${{github.event_name}}-${{github.ref_name}}" | ||
| - "engflow-run-id=${{ github.run_id }}" | ||
| # To avoid a race condition, among all the jobs that use the same Bento in the same repo, only |
There was a problem hiding this comment.
it's not a race condition. The intended use is that one job seeds the snapshot, and multiple jobs (including smaller ones like presubmit-checks) use the snapshot.
Contributor
Author
There was a problem hiding this comment.
Reading the code, looks like if multiple jobs specify engflow-bento-allow-save=true, all of them might take snapshots. I understand that's not the intended use, but if you do do that, isn't that a race condition?
It's not hard to accidentally do it with matrix jobs.
katre
approved these changes
May 26, 2026
Contributor
Author
|
Note about CI failure -- I experimented with different base images in the Bento; failed with one. I restored the original that CI worked with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drive-by: pin actions/checkout to a known-good commit hash